Disconnect feature

[delaaxe]

• Users should be able to add a disconnect button from the their dapp
• Should be in the test dapp as an example

[jgresham]

taking a look

[janek26]

should be just a change in the example dapp jediswap already has this: https://app.testnet.jediswap.xyz/#/swap

[jgresham]

After disconnecting, and then reconnecting, should the user be prompted with this again? (This is not how JediSwap works currently. JediSwap reconnects without requiring this.)

Related, but could be in a new issue, I think with #90 implemented, allowing disconnect to a dapp from extension, there needs to be an event passed to the dapp to know that the user disconnected the dapp from the extension.

[juniset]

Yes, if the user disconnects and reconnects from a dapp he should see the "Connect to a dapp" prompt.

Agree that when the user disconnects from a dapp in the extension an event should be passed to the dapp. We already have the accountsChanged event so we should use the same event but with an empty array. I'll create a separate issue.

[delaaxe]

@juniset We should probably implement the rest of the standard events like 'chainChanged', 'connect', 'disconnect': https://docs.metamask.io/guide/ethereum-provider.html#events

[jgresham]

It seems like the dapp whitelist and if a dapp is connected are separate concepts in current metamask specs.

[delaaxe]

I agree with @jgresham here, on JediSwap clicking on disconnect doesn't remove it from the whitelist

[jasonzhouu]

How about this:

• After the user disconnect from dapp
  • the dapp should stay in the whitelist
  • when the user reconnects from a dapp, should see the "Connect to a dapp" prompt
• if the dapp is in the whitelist and has not disconnected, the next time user opens the dapp, he can connect from dapp without seeing the prompt.

So, when the user disconnects from a dapp, the dapp should stay in the whitelist, and ArgentX record that this dapp has disconnected in the last time.

[delaaxe]

yes this should make more sense

[dhruvkelawala]

I agree with @jgresham here, on JediSwap clicking on disconnect doesn't remove it from the whitelist

Hi, I am leading frontend at JediSwap and I can confirm that we are not "disconnecting" from ArgentX in a proper way. We are just doing a soft disconnect, meaning just removing the currently connected account from the frontend.

We were waiting for a method on Starknet Window Object to implement this method, such as window.starknet.disconnect() which can support removing from the whitelist.

EDIT: SushiSwap also does the same thing as JediSwap when clicking disconnect.

[janek26]

should be solved by https://github.com/argentlabs/argent-x/pull/378 please reopen if that's not the case