argentlabs / starknetkit

MIT License
23 stars 17 forks source link

Argent Webwallet Connector reports an empty address with starknet-react #130

Open jisensee opened 3 months ago

jisensee commented 3 months ago

I have managed to get the webwallet working in my Next.js app with starknet react by upgrading my app to use

Everything kinda works out of the box but the account field that is returned by the useAccount from starknet-react always contains an empty string instead of the actual address, even though I can see that the connector is fetching the accounts from the wallet successfully.

The issue is also present in the example dapp. Everything works but the address is not shown in the UI.

I managed to "fix" it by subclassing the connector and setting the address in the account method manually:

class MyWebWalletConnector extends WebWalletConnector {
  private address?: string

  async connect() {
    const result = await super.connect()
    this.address = result.account
    return result
  }
  async account(provider: ProviderOptions | ProviderInterface) {
    const acc = await super.account(provider)
    if (this.address) {
      acc.address = this.address
    }
    return acc
  }
}

So this seems like an issue with the connector implementation and not with starknet-react to me.

bluecco commented 3 months ago

hi @jisensee, thanks for opening the issue we're currently waiting for starknet-react to publish the latest version in order to make all the fixes needed

will update when it will be done

bluecco commented 1 month ago

starknetkit@latest (2.3.2) is now available and compatible with starknet-react/core@latest (3.0.1)