ConnectorNotConnectedError: Connector not connected

[EvanYan1024]

When I didn’t install a Starknet wallet, I encountered an error when using connect.

It appears in this method mapModalWallets, it reads the name field, but get name throws an error

[bluecco]

hi @EvanYan1024, what do you mean by When I didn’t install a Starknet wallet?

could you give some more details to understand the issue and how to reproduce?

[EvanYan1024]

@bluecco, hello，This means that when my browser does not have the argentX and braavos extensions installed, for example, you can open the page in incognito mode, and this error will appear.

[bluecco]

@EvanYan1024 I've tried to replicate with my local dapp, but I cannot achieve the same error (this is brave incognito, also tried with chrome and firefox incognito)

https://github.com/argentlabs/starknetkit/assets/7635032/601abfdb-23a1-4a9a-afc8-e982feea2499

Also no exceptions throwed (checked the console log too)

Could you share:

• the starknetkit version you're using
• code (or the snippet) that implements starknetkit?

[EvanYan1024]

@bluecco Thanks for your reply, you can try edge browser， I guess this is the reason, you can check out my PR。 https://github.com/starknet-io/get-starknet/pull/207/files

[bluecco]

@EvanYan1024 sorry for the delay, we're still waiting for the linked pr to be merged (and then update get-starknet react here)

[YanYuanFE]

@bluecco Thanks for your reply. It seems that the get-starknet library is no longer updated.

[lazarmitic]

We also have same issue in our dApp on Edge browser, is there a workaround, or we need to wait for get-starknet to merge above PR? Can we replace getDiscoveryWallets() from starknet-core with our own version and put it in starknet-kit?

[YanYuanFE]

@lazarmitic ，hi，you can use patch package to fix get-starknet, https://www.npmjs.com/package/patch-package

[TEMHITHORPHE]

@bluecco Thanks for your reply, you can try edge browser， I guess this is the reason, you can check out my PR。 https://github.com/starknet-io/get-starknet/pull/207/files

This has been merged now, any updates ?

[bluecco]

@TEMHITHORPHE pr is opened, should be merged tomorrow (after internal testing) https://github.com/argentlabs/starknetkit/pull/97

[bluecco]

will need this pr to be merged first

https://github.com/starknet-io/get-starknet/pull/238

otherwise, current implementation will break ssr (ie: using nextjs)

[arentant]

@TEMHITHORPHE pr is opened, should be merged tomorrow (after internal testing) #97

Hi, any updates?

[bluecco]

@arentant the pr on get-starknet is merged but not released checking with starknetjs team

[bluecco]

it will be published after the merge of https://github.com/starknet-io/get-starknet/pull/244