search

argentlabs / web3.swift

Ethereum Swift API with support for smart contracts, ENS & ERC20
MIT License
674 stars 169 forks source link

Support Custom Typed Array #279

Closed joshuajiangdev closed 1 year ago

joshuajiangdev commented 1 year ago

Context: https://github.com/argentlabs/web3.swift/issues/277

Adding support of custom typed array in signableHash. Cross verified new unit test cases with @metamask/eth-sig-util.

Tests:

  1. All unit tests in EthereumAccount_SignTypedTests
joshuajiangdev commented 1 year ago

Hmmm, seems the unexpected failures are not from the unit tests I modified 

Test Suite 'EthereumWebSocketClientTests' failed at 2022-11-16 15:14:59.359.
     Executed 33 tests, with 35 failures (3 unexpected) in 5.265 (5.267) seconds

Any suggestion here?

joshuajiangdev commented 1 year ago

Hmmmm 1 workflow awaiting approval has been stucked for 1 day. How to resolve this?

First-time contributors need a maintainer to approve running workflows. Could I get approve to run the workflows?

joshuajiangdev commented 1 year ago

in macos workflow, I'm seeing

Test Suite 'EthereumWebSocketClientTests' failed at 2022-11-18 08:45:31.549.
     Executed 33 tests, with 35 failures (3 unexpected) in 4.931 (4.933) seconds

in linux workflow, I'm seeing

Test Suite 'All tests' failed at 2022-11-18 09:10:51.236
     Executed 307 tests, with 111 failures (0 unexpected) in 1634.268 (1634.268) seconds
Error: Process completed with exit code 1.

Two questions here:

  1. Linux workflow seems do not have unexpected errors, but it still shows blocked/failed?
  2. The macos workflow seems also have unexpected fails without my change eg. develop branch.

If both failures are expected, how could I land with two workflows to be in the failure state?

DarthMike commented 1 year ago

@joshuajiangdev We need to migrate to Goerli for tests to pass. Will take this task this week and we can update your PR with that changes so tests pass. Will let you know about progress (https://github.com/argentlabs/web3.swift/issues/234)

DarthMike commented 1 year ago

@joshuajiangdev #281 should fix the tests