search

argentlabs / web3.swift

Ethereum Swift API with support for smart contracts, ENS & ERC20
MIT License
668 stars 168 forks source link

Inconsistent dependencies for Secp256k1.swift between swift package manager and cocoapods #341

Closed metalurgical closed 9 months ago

metalurgical commented 11 months ago

The dependencies between the SPM and Cocoapods are inconsistent.

Secp256k1.swift for SPM uses the GigaBitcoin repository:

.package(url: "https://github.com/GigaBitcoin/secp256k1.swift.git", .upToNextMajor(from: "0.6.0")),

Secp256k1.swift for CocoaPods uses the BoilerTalk repository:

s.dependency 'secp256k1.swift', '~> 0.1'

https://cocoapods.org/pods/secp256k1.swift

These need to be reconciled.

DarthMike commented 9 months ago

Using Cocoapods is considered legacy and we don't actively support it. the correct version should be the one on SPM. We'll reconcile in an upcoming release.

Thanks for reporting

DarthMike commented 9 months ago

Unfortunately not all libraries offer Cocoapods. Specifically GigaBitcoin doesn't. We'll need to leave this as-is, and will remove Cocoapods support soon. Added a warning to README #348