search

argentlabs / web3.swift

Ethereum Swift API with support for smart contracts, ENS & ERC20
MIT License
668 stars 168 forks source link

bump: update bigint in podspec #370

Open metalurgical opened 4 months ago

metalurgical commented 4 months ago

BigInt 5.3 (as defined in the spm package) is not backwards compatible beyond 5.2 (as defined in the cocoapods package).

There are missing extensions.

DarthMike commented 2 months ago

Hi @metalurgical we already updated to 5.3, even if not backwards compatible. Better to keep the versions aligned (SPM vs Cocoapods)

metalurgical commented 2 months ago

Hi @DarthMike.

Perhaps the explanation was unclear.

The latest BigInt release on Cocoapods is 5.2. On Swift Package Manager it is 5.3.

BigInt 5.2 is compatible with BigInt 5.3, except for a couple extensions added in 5.3.

However versions before 5.2 are very difficult to be compatible with 5.3 so the cocoapods version needs to be updated.

Does this explain it better?

DarthMike commented 2 months ago

@metalurgical Thanks for clarification. I see what you mean, but if we update the podspec I think we should bump to be using minimum 5.3 as we do for SPM. Even if we're forcing an update of the library it's going to be better longer term.

Are there any other common libraries that will not be compatible if it's bumped to 5.3?