Closed burtenshaw closed 5 days ago
LFTM! One remark, are we testing this flow somewhere, otherwise we can update it?
No. I could unit test the client attribute.
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@davidberenstein1957 Thanks for pointing me to testing. On closer inspection I realised that the docs were wrong and we should be using headers
not extra_headers
.
@frascuchon can you confirm this please?
@davidberenstein1957 Thanks for pointing me to testing. On closer inspection I realised that the docs were wrong and we should be using
headers
notextra_headers
.@frascuchon can you confirm this please?
Yes, @burtenshaw. the Argilla client exposes the httpx.Cient init args in the extra kwargs. Let us add some docs to the Argilla.init describing this (as we do with the APIClient definition
We already have some unit tests checking this https://github.com/argilla-io/argilla/blob/fix/extra-headers/argilla/tests/unit/api/http/test_http_client.py
This PR passes the extra headers pass to
Argilla
down to the http client so that argilla sdk can be used with authenticate deployment like provate HF spaces.How Has This Been Tested
Checklist