search

argilla-io / argilla

Argilla is a collaboration tool for AI engineers and domain experts to build high-quality datasets
https://docs.argilla.io
Apache License 2.0
3.83k stars 360 forks source link

[FEATURE] relax `typer` constraints #5104

Closed davidberenstein1957 closed 2 months ago

davidberenstein1957 commented 3 months ago

Is your feature request related to a problem? Please describe. Currently, Argilla 1 depends on typer <0.10 but currently typer is at 0.13 so it might be worth relaxing these constraitns.

Describe the solution you'd like relax the contraints

Describe alternatives you've considered N.A.

Additional context N.A.

frascuchon commented 3 months ago

we shouldn't change argilla-v1 setup. As far as I understand this problem exists already with argilla<2.0.0 right?

The argilla-v1 is a renamed package to support both SDK versions, but its behavior shouldn't be modified.

davidberenstein1957 commented 3 months ago

Yes, it did, however, given that we do intend to dedicate to support fixes, I am not sure if we don't want to support things like this at all or just only want to do explicit bug fixes.

I don't know what is common practice for relaxing version constraints after deprecation but it doesn't sound very weird to do this for a certain period.

davidberenstein1957 commented 2 months ago

Partially resolved through this PR https://github.com/argilla-io/argilla/pull/5164