argilla-io / argilla

Argilla is a collaboration tool for AI engineers and domain experts to build high-quality datasets
https://docs.argilla.io
Apache License 2.0
4.04k stars 381 forks source link

[CONFIG] `argilla`: Add Python 3.13 support #5652

Closed frascuchon closed 2 weeks ago

frascuchon commented 3 weeks ago

Description

Closes https://github.com/argilla-io/argilla/issues/5627

Type of change

How Has This Been Tested

Checklist

frascuchon commented 3 weeks ago

Problems using python 3.13 + pyarrow https://github.com/apache/arrow/issues/44443

oulianov commented 3 weeks ago

The dependencies install pyarrow 17.0.0, but python 3.13 is only supported for pyarrow 18.0.0 (released 2 days ago) https://github.com/apache/arrow/issues/43519

oulianov commented 3 weeks ago

I ran pdm lock with the latest pdm version using your pyproject.toml file. The solver gave me the right version of pyarrow (18.0).

Capture d’écran 2024-10-30 à 17 33 18

So my guess is you just need to run pdm lock again and tests will pass for 3.13 :)

Let me know how it goes.

frascuchon commented 3 weeks ago

Thanks for the tip @oulianov. The pdm lock will update other dependencies making the whole workflow fails.

I defined the 18.0.0 as a dev dependency and everything is working.

@burtenshaw I think this is ready to merge.