argilla-io / argilla

Argilla is a collaboration tool for AI engineers and domain experts to build high-quality datasets
https://docs.argilla.io
Apache License 2.0
4k stars 378 forks source link

[BUGFIX] `argilla frontend`: Avoid call router.push when opening an external URL #5675

Closed frascuchon closed 2 weeks ago

frascuchon commented 2 weeks ago

Description

This PR fixes the router.go method and avoids calling router.push when the external flag is True

Type of change

How Has This Been Tested

Checklist

github-actions[bot] commented 2 weeks ago

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-5675-ki24f765kq-no.a.run.app

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.08%. Comparing base (229809e) to head (78a8536).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5675 +/- ## =========================================== - Coverage 91.10% 91.08% -0.02% =========================================== Files 150 150 Lines 6250 6250 =========================================== - Hits 5694 5693 -1 - Misses 556 557 +1 ``` | [Flag](https://app.codecov.io/gh/argilla-io/argilla/pull/5675/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argilla-io) | Coverage Δ | | |---|---|---| | [argilla-server](https://app.codecov.io/gh/argilla-io/argilla/pull/5675/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argilla-io) | `91.08% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argilla-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.