search

argiopetech / base

Bayesian Analysis for Stellar Evolution
http://webfac.db.erau.edu/~vonhippt/base9/
11 stars 4 forks source link

Missing CHAB variables #27

Closed argiopetech closed 11 years ago

argiopetech commented 11 years ago

If loading CHAB models, mpiMcmc still requests two variables from the command line.

    /* open model file, choose model set, and load models */
    if (settings.mainSequence.msRgbModel == CHABHELIUM)
    {
        scanf ("%lf %lf", &ctrl.priorMean[YYY], &ctrl.priorVar[YYY]);

        if (ctrl.priorVar[YYY] < 0.0)
        {
            ctrl.priorVar[YYY] = 0.0;
        }
    }
tedvh commented 11 years ago

Right. These are the subset of models that have a range of helium (Y), so they need a helium prior value and prior sigma.

On 7/4/13 12:57 PM, Elliot Robinson wrote:

If loading CHAB models, mpiMcmc still requests two variables from the command line.

 /* open model file, choose model set, and load models */
 if  (settings.mainSequence.msRgbModel  ==  MsModel::CHABHELIUM)
 {
     scanf  ("%lf %lf",  &ctrl.priorMean[YYY],  &ctrl.priorVar[YYY]);

     if  (ctrl.priorVar[YYY]  <  0.0)
     {
         ctrl.priorVar[YYY]  =  0.0;
     }
 }

— Reply to this email directly or view it on GitHub https://github.com/argiopetech/base/issues/27.

Ted von Hippel

Department of Physical Sciences Embry-Riddle Aeronautical University 600 S. Clyde Morris Boulevard Daytona Beach, FL 32114-3900 386-226-7751

argiopetech commented 11 years ago

This block of code will fix the issue if anyone needs to use the Chab models between now and the 9.3.0 release. A modified version of this code is already in the cpp_conversion branch and will be in 9.3.0.

    if (settings.mainSequence.msRgbModel == CHABHELIUM)
    {
        ctrl.priorMean[YYY] = settings.cluster.Y;
        ctrl.priorVar[YYY] = settings.cluster.sigma.Y;
    }
    else
    {
        ctrl.priorMean[YYY] = 0.0;
        ctrl.priorVar[YYY] = 0.0;
    }
tedvh commented 11 years ago

Thanks Elliot.

This might be relevant to your work David, so I'm cc'ing you on this.

-Ted

On 7/4/13 4:41 PM, Elliot Robinson wrote:

This block of code will fix the issue if anyone needs to use the Chab models between now and the 9.3.0 release. A modified version of this code is already in the cpp_conversion branch and will be in 9.3.0.

 if  (settings.mainSequence.msRgbModel  ==  CHABHELIUM)
 {
     ctrl.priorMean[YYY]  =  settings.cluster.Y;
     ctrl.priorVar[YYY]  =  settings.cluster.sigma.Y;
 }
 else
 {
     ctrl.priorMean[YYY]  =  0.0;
     ctrl.priorVar[YYY]  =  0.0;
 }

— Reply to this email directly or view it on GitHub https://github.com/argiopetech/base/issues/27#issuecomment-20492952.

Ted von Hippel

Department of Physical Sciences Embry-Riddle Aeronautical University 600 S. Clyde Morris Boulevard Daytona Beach, FL 32114-3900 386-226-7751