search

argiopetech / base

Bayesian Analysis for Stellar Evolution
http://webfac.db.erau.edu/~vonhippt/base9/
11 stars 4 forks source link

fgets segfault on Zeus #29

Closed argiopetech closed 11 years ago

argiopetech commented 11 years ago

libc-2.5, Zeus's resident dinosaur of an excuse for libc, segfaults in YaleMsModel.cpp due to a null file handle, despite the fact that it should, presumably, not be closeable at that point in the code.

I have not been able to reproduce this on any other machine, so I'm going to rewrite the MsModels to use C++ streams instead of the old C-style file IO.

tedvh commented 11 years ago

sure. whatever you think is a good approach.

On 7/11/13 12:26 AM, Elliot Robinson wrote:

libc-2.5, Zeus's resident dinosaur or an excuse for libc, segfaults in YaleMsModel.cpp due to a null file handle, despite the fact that it should, presumably, not be closeable at that point in the code.

I have not been able to reproduce this on any other machine, so I'm going to rewrite the MsModels to use C++ streams instead of the old C-style file IO.

— Reply to this email directly or view it on GitHub https://github.com/argiopetech/base/issues/29.

Ted von Hippel

Department of Physical Sciences Embry-Riddle Aeronautical University 600 S. Clyde Morris Boulevard Daytona Beach, FL 32114-3900 386-226-7751

argiopetech commented 11 years ago

This issue was related to file handling in one of the MS models. The model has been switched from the C-style file loading to C++ stream-based loading, and feels much better.

tedvh commented 11 years ago

good work on #29.

On 7/19/13 12:01 PM, Elliot Robinson wrote:

This issue was related to file handling in one of the MS models. The model has been switched from the C-style file loading to C++ stream-based loading, and feels much better.

After this fix, an additional segfault issue remained. This issue is detailed in

34.

— Reply to this email directly or view it on GitHub https://github.com/argiopetech/base/issues/29#issuecomment-21259027.

argiopetech commented 11 years ago

All mention of the fictitious #34 has been removed. We don't pre-allocate the grid any more (it's computed dynamically), so it isn't an issue.

tedvh commented 11 years ago

cool!

On 7/19/13 4:21 PM, Elliot Robinson wrote:

All mention of the fictitious #34 has been removed. We don't pre-allocate the grid any more (it's computed dynamically), so it isn't an issue.

— Reply to this email directly or view it on GitHub https://github.com/argiopetech/base/issues/29#issuecomment-21274909.

Ted von Hippel

Department of Physical Sciences Embry-Riddle Aeronautical University 600 S. Clyde Morris Boulevard Daytona Beach, FL 32114-3900 386-226-7751