search

argiopetech / base

Bayesian Analysis for Stellar Evolution
http://webfac.db.erau.edu/~vonhippt/base9/
11 stars 4 forks source link

remove temporary NS settings from scatterCluster.c #31

Closed tedvh closed 11 years ago

tedvh commented 11 years ago

For some debugging reason, NS went through and made a number of temporary changes to scatterCluster.c. These should be restored to their default conditions. Examples below (comments should be uncommented, TEMPORARY line should be removed):

// clusterMemberPrior = (double) nStars / (nStars + nFieldStars);
// if(clusterMemberPrior > 0.99) clusterMemberPrior = 0.99;
    clusterMemberPrior = 1.0; // NS TEMPORARY!!!

// if(sigma[filt] < 0.005) sigma[filt] = 0.005; // NS TEMPORARY!!
    if(sigma[filt] < 0.01) sigma[filt] = 0.01;
      // phot[filt] += gen_norm(0., sigma[filt]);
      phot[filt] += gen_norm(0., 3*sigma[filt]); // NS TEMPORARY!!!

Part of the above case is an exception. Please keep the sigma=0.01 line and not the sigma=0.005 line.

// else fprintf(w_ptr,"%8.6f ",sigma[filt]);
  else fprintf(w_ptr,"%8.6f ",sigma[filt]*sigma[filt]); // TEMPORARY!!!

The above is printing out variance, and it should be the first line to print out sigma.

// if(stage1 == BD) fprintf(w_ptr,"%8.6f ",sigma[filt]);
if(stage1 == BD) fprintf(w_ptr,"%8.6f ",sigma[filt]*sigma[filt]); // TEMPORARY!!!

ditto.

argiopetech commented 11 years ago

I'd appreciate it if you can review the changes linked from 9a9929d. If they're okay, we can go ahead and close this.