search

argiopetech / base

Bayesian Analysis for Stellar Evolution
http://webfac.db.erau.edu/~vonhippt/base9/
11 stars 4 forks source link

Better filterSet handling #36

Closed argiopetech closed 11 years ago

argiopetech commented 11 years ago

Either:

  1. Automatically determine which filterSet a given photometry file is using based on the header, or
  2. Ensure that a at least one filter was loaded from the user-specified filterSet, or
  3. Check the size of the filter vector every time it is used. (Don't do this).

In addition, assert filters.size > 0 whenever we use filters.front() or filters.back()

Rationale

Loading a photometry file with the wrong filterSet results in a zero-length vector. This causes segfaults when we use .front() without checking size.

argiopetech commented 11 years ago

Went with option 2 for the moment. Will be adding option 1 as a new issue in the "| milestone.

tedvh commented 11 years ago

sure.

On 7/22/13 3:48 PM, Elliot Robinson wrote:

Went with option #2 https://github.com/argiopetech/base/issues/2 for the moment. Will be adding option #1 https://github.com/argiopetech/base/issues/1 as a new issue in the /|/ milestone.

— Reply to this email directly or view it on GitHub https://github.com/argiopetech/base/issues/36#issuecomment-21370530.

Ted von Hippel

Department of Physical Sciences Embry-Riddle Aeronautical University 600 S. Clyde Morris Boulevard Daytona Beach, FL 32114-3900 386-226-7751