search

argiopetech / base

Bayesian Analysis for Stellar Evolution
http://webfac.db.erau.edu/~vonhippt/base9/
11 stars 4 forks source link

ACS and UVIS filters can not be loaded #57

Closed argiopetech closed 9 years ago

argiopetech commented 10 years ago

Problem

The Bergeron WD Atmosphere models do not allow ACS and UVIS filters to be loaded, as these filters are not available in the Bergeron models.

Proposed fix

Disable WD model loading when ACS or UVIS filters are selected. This will ("may" for smart pointer?) cause a null pointer dereference segfault if WDs are used.

Proper handling implies we should also do WD-related things (WD branch in mpiMcmc, creation of WDs in simCluster) when the UBVRIJHK or SDSS filters are selected.

Alternative fix

Alternatively, create a new "Invalid" WD and MS model which throws an exception if called. Additionally, add logic to loadModel to call an bool isSupported(FilterSet) style function in every potential model, using an Invalid[MS|WD]Model if the filterSet is not supported and printing a warning message. bool InvalidModel::isSupported(FilterSet) should return false for all filter sets.

This has the benefit of at least printing an error message if the user calls models which are not supported under the current filterSet. This would also be a fix to #52 and #26.