Disallow invalid `--language` values - Githubissues

argmaxinc / WhisperKit

On-device Speech Recognition for Apple Silicon

http://argmaxinc.com/blog/whisperkit

MIT License

3.92k stars 330 forks source link

Disallow invalid `--language` values #116

Closed jkrukowski closed 7 months ago

jkrukowski commented 7 months ago

Should resolve https://github.com/argmaxinc/WhisperKit/issues/103

In this PR:

added CLI lang code validation using https://apple.github.io/swift-argument-parser/documentation/argumentparser/validation/

Minor improvements:

allLanguageTokens becomes a set and a part of WhisperTokenizer protocol
allLanguageTokens is computed just once -- this property is used in text decoding, computing it for every decoding operation might be expensive