Fix silence detection - Githubissues

aigerimmmm commented 4 months ago

PR for the issue https://github.com/argmaxinc/WhisperKit/issues/27.

Added SilenceDetectionFilter similar to LanguageDetectionFilter.
Implemented detectSilence similar to detectLanguage in TextDecoder that does a single forward pass from to detect silence periods.
Added tests for SilenceDetectionFilter.
Added silence detection and segment skipping logic in TranscribeTask.
Updated models to support silence detection:
- Added flags in DecodingOptions for ignoring prefill prompts during silence detection.
- Changed property for managing silence detection threshold.

ZachNagengast commented 4 months ago

Hey @aigerimmmm just checking in, how are you feeling about the changes?

aigerimmmm commented 4 months ago

Hi @ZachNagengast, I really appreciate the all suggestions and detailed review, it's very helpful for me 👍 I've been working on it and I'm going to submit today.

ZachNagengast commented 3 months ago

@aigerimmmm Checking in, is this ready for another review?

aigerimmmm commented 3 months ago

Hi @ZachNagengast thank you for reply, yes I am ready anytime for another review.

argmaxinc / WhisperKit

Fix silence detection #175