WhisperKit CLI cleanup - Githubissues

argmaxinc / WhisperKit

On-device Speech Recognition for Apple Silicon

http://argmaxinc.com/blog/whisperkit

MIT License

3.92k stars 331 forks source link

WhisperKit CLI cleanup #68

Closed jkrukowski closed 8 months ago

jkrukowski commented 8 months ago

Before taking on https://github.com/argmaxinc/WhisperKit/issues/36 I decided to do a little cleanup in the CLI

moved command line arguments to a separate WhisperKitArguments struct
extracted a separate transcribe subcommand
changed executable name to whisper-kit

so rn in order to run the transcribe command the user has to type swift run whisper-kit transcribe It's going to be convenient if we're going to add more subcommands in future (e.g. swift run whisper-kit translate)

jkrukowski commented 8 months ago

Good thinking in general with the cleanup, however this will break quite a bit of our benchmark/eval code as is, because it calls this function from python as a shell command, and would require updating all of that as well. If this is a blocker for the homebrew PR then we should discuss further, otherwise it would be ideal to keep the interfaces the same.

Sounds fair. I could potentially add a PR in https://github.com/argmaxinc/whisperkittools repo to accommodate for these changes but I understand the concern. I reverted the renaming part, please take a 2nd look @ZachNagengast