argmaxinc / WhisperKit

On-device Speech Recognition for Apple Silicon
https://takeargmax.com/blog/whisperkit
MIT License
3.17k stars 268 forks source link

temperatureStart is unused #93

Closed cgfarmer4 closed 6 months ago

cgfarmer4 commented 6 months ago

I dont see temperatureStart being used anywhere in the repo, however it exists in the settings view. Is this intentional? Shouldnt it be passed to DecodingOptions? Same for fallbackCount.

ZachNagengast commented 6 months ago

You're right, this is an oversight! Will get this in the next release 👍

cgfarmer4 commented 6 months ago

Cool, I can PR later this week too.