argmin-rs / argmin

Numerical optimization in pure Rust
http://argmin-rs.org
Apache License 2.0
972 stars 76 forks source link

Fix steepest descent to cache previous param #363

Closed DevonMorris closed 1 year ago

DevonMorris commented 1 year ago

As discussed in https://github.com/argmin-rs/argmin/issues/362

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ae98919) 93.35% compared to head (71432a6) 93.36%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #363 +/- ## ======================================= Coverage 93.35% 93.36% ======================================= Files 117 117 Lines 18803 18819 +16 ======================================= + Hits 17554 17570 +16 Misses 1249 1249 ``` | [Impacted Files](https://app.codecov.io/gh/argmin-rs/argmin/pull/363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argmin-rs) | Coverage Δ | | |---|---|---| | [...gmin/src/solver/gradientdescent/steepestdescent.rs](https://app.codecov.io/gh/argmin-rs/argmin/pull/363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argmin-rs#diff-YXJnbWluL3NyYy9zb2x2ZXIvZ3JhZGllbnRkZXNjZW50L3N0ZWVwZXN0ZGVzY2VudC5ycw==) | `95.62% <100.00%> (+0.57%)` | :arrow_up: | | [argmin/src/solver/linesearch/backtracking.rs](https://app.codecov.io/gh/argmin-rs/argmin/pull/363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argmin-rs#diff-YXJnbWluL3NyYy9zb2x2ZXIvbGluZXNlYXJjaC9iYWNrdHJhY2tpbmcucnM=) | `99.05% <100.00%> (ø)` | | | [argmin/src/solver/linesearch/hagerzhang.rs](https://app.codecov.io/gh/argmin-rs/argmin/pull/363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argmin-rs#diff-YXJnbWluL3NyYy9zb2x2ZXIvbGluZXNlYXJjaC9oYWdlcnpoYW5nLnJz) | `73.89% <100.00%> (ø)` | | | [argmin/src/solver/linesearch/mod.rs](https://app.codecov.io/gh/argmin-rs/argmin/pull/363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argmin-rs#diff-YXJnbWluL3NyYy9zb2x2ZXIvbGluZXNlYXJjaC9tb2QucnM=) | `77.27% <100.00%> (ø)` | | | [argmin/src/solver/linesearch/morethuente.rs](https://app.codecov.io/gh/argmin-rs/argmin/pull/363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argmin-rs#diff-YXJnbWluL3NyYy9zb2x2ZXIvbGluZXNlYXJjaC9tb3JldGh1ZW50ZS5ycw==) | `86.60% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.