argo0n / NograBot

Discord.py bot written by Argon#0002
GNU General Public License v3.0
2 stars 1 forks source link

Updating hug command : Using an API for gif gen (Sourcery refactored) #102

Closed sourcery-ai[bot] closed 3 years ago

sourcery-ai[bot] commented 3 years ago

Pull Request #101 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to the original Pull Request

    Incorporate changes via command line
    git fetch https://github.com/argo0n/NograBot pull/101/head
    git merge --ff-only FETCH_HEAD
    git push

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Help us improve this pull request!

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.13%.

Quality metrics Before After Change
Complexity 6.68 ⭐ 6.69 ⭐ 0.01 👎
Method Length 80.41 🙂 80.59 🙂 0.18 👎
Working memory 14.93 😞 14.95 😞 0.02 👎
Quality 52.28% 🙂 52.15% 🙂 -0.13% 👎
Other metrics Before After Change
Lines 245 239 -6
Changed files Quality Before Quality After Quality Change
cogs/fun.py 52.28% 🙂 52.15% 🙂 -0.13% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
cogs/fun.py Fun.cog_command_error 16 🙂 326 ⛔ 23 ⛔ 23.78% ⛔ Try splitting into smaller methods. Extract out complex expressions
cogs/fun.py Fun.dumbfight 5 ⭐ 230 ⛔ 19 ⛔ 39.80% 😞 Try splitting into smaller methods. Extract out complex expressions
cogs/fun.py Fun.blacklist 5 ⭐ 175 😞 12 😞 51.88% 🙂 Try splitting into smaller methods. Extract out complex expressions
cogs/fun.py Fun.bon 3 ⭐ 101 🙂 15 😞 58.00% 🙂 Extract out complex expressions
cogs/fun.py Fun.hug 4 ⭐ 109 🙂 12 😞 60.18% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

argo0n commented 3 years ago

Wait I just merged it too didn't I

argo0n commented 3 years ago

Well, fu

Maple06 commented 3 years ago

yea LMAOOO u merged the refactored one

Maple06 commented 3 years ago

i think