search

argo0n / NograBot

Discord.py bot written by Argon#0002
GNU General Public License v3.0
2 stars 1 forks source link

Experiment changing timezone to Asia/Singapore (Sourcery refactored) #55

Closed sourcery-ai[bot] closed 3 years ago

sourcery-ai[bot] commented 3 years ago

Pull Request #54 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the argon-cleanup-fixes branch, then run:

git fetch origin sourcery/argon-cleanup-fixes
git merge --ff-only FETCH_HEAD
git reset HEAD^
sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.42%.

Quality metrics Before After Change
Complexity 4.73 ⭐ 4.81 ⭐ 0.08 👎
Method Length 46.92 ⭐ 46.67 ⭐ -0.25 👍
Working memory 10.70 😞 10.79 😞 0.09 👎
Quality 64.45% 🙂 64.03% 🙂 -0.42% 👎
Other metrics Before After Change
Lines 95 94 -1
Changed files Quality Before Quality After Quality Change
cogs/Moderation.py 64.45% 🙂 64.03% 🙂 -0.42% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
cogs/Moderation.py Moderation.clear 10 🙂 197 😞 12 😞 45.30% 😞 Try splitting into smaller methods. Extract out complex expressions
cogs/Moderation.py Moderation.on_message 7 ⭐ 134 😞 18 ⛔ 46.94% 😞 Try splitting into smaller methods. Extract out complex expressions
cogs/Moderation.py Moderation.uptime 1 ⭐ 105 🙂 11 😞 65.43% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.