argoflow / argoflow-aws

Argoflow-AWS has been superseded by deployKF
GNU Affero General Public License v3.0
44 stars 30 forks source link

[OAuth2-Proxy] Timeout issue - refresh of cookies doesnt seem to work as anticipated #202

Closed jaystary closed 3 years ago

jaystary commented 3 years ago

Hello,

we noticed an "issue" here https://github.com/argoflow/argoflow-aws/blob/master/distribution/oidc-auth/base/oauth2-proxy.yaml

 - name: extraArgs.cookie-refresh
        value: 1h
      - name: extraArgs.cookie-expire
        value: 4h

The refresh doesnt seem to get updated as anticipated, at least not with the setup of redis as session store. When you then use the application, this will lead to frequent timeouts (401) after a while after which you have to reauthenticate - but this still doesnt really fix the problem for another 4 hours, after that it seems to become non deterministic at least from what i observed.

Obv this is not the root of the issue, but would it be possible to increase this value or allow to use for parameterization so that we can define our own value until the root cause is fixed? Suggestions / ideas how we should tackle this?

Thanks

matkosoric commented 3 years ago

Fixed in PR 205