search

argoflow / argoflow-aws

Argoflow-AWS has been superseded by deployKF
GNU Affero General Public License v3.0
44 stars 30 forks source link

[OAuth2-Proxy] Timeout issue - refresh of cookies doesnt seem to work as anticipated #221

Closed jaystary closed 3 years ago

jaystary commented 3 years ago

This seems to still not working as anticiapted:

https://github.com/argoflow/argoflow-aws/issues/202

We tried with GitLab IdP and the increase in time kept the app alive.

We then applied it to Okta, which in that specific case had a global setting that couldnt be changed for 4 hours expiry, and it keeps timing out (despite the OAuth cookie being set on the long period).

Thus we will keep investigating and probably have to understand how to make the refresh correctly working.

jaystary commented 3 years ago

So for whatever reason, whilst working with Okta, it seems that the refresh is not properly working and when the configured time hits (by default 1h) it invalidates the cookie but doesnt present a new one. We updated this now and this actually works fine if anyone would ever run into this issue (lets ignore for a sec that there is a reason why those cookies should be refreshed in short intervals)

 - name: extraArgs.cookie-refresh
        value: 72h #or whatever floats your boat
 - name: extraArgs.cookie-expire
        value: 72h