argoflow / argoflow-aws

Argoflow-AWS has been superseded by deployKF
GNU Affero General Public License v3.0
44 stars 30 forks source link

QUESTION: roleArns for external-secrets when using Option 1 #229

Open jai opened 2 years ago

jai commented 2 years ago

Hi - when using Option 1 for the external-secrets role, what are the expected values to be placed in setup.conf for the following lines?

# This uses the external-secrets role
---
<<__role_arn.external_secrets__>>=arn:aws:iam::106256755710:role/external_secrets_role

# When using Option 1 there aren't any of the roles below, do we just pass in the external_secrets_role?
---
<<__role_arn.cert_manager__>>=arn:aws:iam::106256755710:role/cert_manager_role
<<__role_arn.external_dns__>>=arn:aws:iam::106256755710:role/external_dns_role
<<__role_arn.oauth2_proxy__>>=arn:aws:iam::106256755710:role/external_secrets_auth_role
<<__role_arn.external_secrets.mlflow__>>=arn:aws:iam::106256755710:role/external_secrets_role
<<__role_arn.external_secrets.kubeflow__>>=arn:aws:iam::106256755710:role/external_secrets_role
<<__role_arn.external_secrets.argocd__>>=arn:aws:iam::106256755710:role/external_secrets_role
<<__role_arn.external_secrets.auth__>>=arn:aws:iam::106256755710:role/external_secrets_role
<<__role_arn.external_secrets.istio_system__>>=arn:aws:iam::106256755710:role/external_secrets_role
alfredox10 commented 2 years ago

If you went with option one, you can delete those lines from the config files, they aren't needed.