argoflow / argoflow-aws

Argoflow-AWS has been superseded by deployKF
GNU Affero General Public License v3.0
44 stars 30 forks source link

MLflow in central dashboard is not a valid page #233

Open amybachir opened 2 years ago

amybachir commented 2 years ago

Hi! I'm running off latest commit in argoflow as of today (commit hash cdce0fc7a9fc72d00f0fad911b015bff4016e585) and I have central-dashboard-mlflow turned on. I can see the mlflow tab in the central dashboard but it returns Sorry, /mlflow/abachir/ is not a valid page for my user when I click on it

image

amybachir commented 2 years ago

It seems there is no virtual service created for the mlflow service. I created the following virtual service:

apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
    name: mlflow
    namespace: mlflow
spec:
  gateways:
  - kubeflow/kubeflow-gateway
  hosts:
  - YOUR_DOMAIN_NAME
  http:
  - headers:
      request:
        add:
          x-forwarded-prefix: /mlflow
    match:
    - uri:
        prefix: /mlflow/
    rewrite:
      uri: /
    route:
    - destination:
        host: mlflow.mlflow.svc.cluster.local
        port:
          number: 80

Also, since there isn't a deployment of mlflow in every user namespace, it shouldn't be namespaced in the central dashboard configmap so I removed the ns variable from there:

{
          "type": "item",
          "link": "/mlflow/",
          "text": "MLFlow",
          "icon": "maps:layers"
        }

Now MLflow app shows up correctly in the central dashboard:

Screen Shot 2021-10-09 at 2 09 18 PM
jai commented 2 years ago

Are you accessing the console via port-forwarding or through the publicly-mapped FQDN?

amybachir commented 2 years ago

Are you accessing the console via port-forwarding or through the publicly-mapped FQDN?

I’m using a public domain name.