search

argonlaser / badgeit-front

Front service for badgeit
http://badgeit.today/
MIT License
0 stars 1 forks source link

Fix socket broadcasting bug #13

Closed scriptnull closed 7 years ago

scriptnull commented 7 years ago
  1. Open three tabs
  2. go to badgeit-front.now.sh on all the three tabs
  3. choose three different github repos and input them on the search box and press enter one by one.
  4. If we open the console in tab1, we should receive the payload only for its respective git repo. But thats not the case right now. Along with the payload result for tab1, tab1 also receives the payload results of tab2 and tab3
argonlaser commented 7 years ago

As discussed, we have a room with key as repo and add clients who subscribe to the room. Emit data to all people in that room so that they are notified of the changes if any.

argonlaser commented 7 years ago

Depends on https://github.com/scriptnull/badgeit/issues/14/.

argonlaser commented 7 years ago

scriptnull/badgeit#14 is done. https://github.com/argonlaser/badgeit-front/pull/25 will address this issue. Tested locally. Will close once checked on production.

argonlaser commented 7 years ago

Tested. Its working as expected. Hence closing it.