argonne-lcf / THAPI

A tracing infrastructure for heterogeneous computing applications.
Other
22 stars 9 forks source link

Hip interval to metababel #158

Closed DonAurelio closed 11 months ago

DonAurelio commented 11 months ago
TApplencourt commented 11 months ago

Stil working on the Makefile, distcheck still not working :(

Haha, got beaten by that many time :) We can have a look together on Monday. Look like you forgot add

I think, the CI doesn't pass because the gemm have not updated.

DonAurelio commented 11 months ago

I think we are goo now.

DonAurelio commented 11 months ago

We can void the $(srcdir) in the dependencies since btx_interval_model.yaml and btx_timeline_params.yaml are in EXTRA_DIST, that's why it works before. This tells Make that those dependencies exist and we need to copy them for distribution (only when make dist is issued, not during build).

Then, it is mandatory to place $(srcdir) in the command since those files won't be present in the build dir when we issue make. I chose to keep $(srcdir) in the dependencies to tell this dependencies are not in the build directory at build time (make). What do you think?

$(BTX_TIMELINE_GENERATED) &: $(srcdir)/btx_interval_model.yaml $(srcdir)/btx_timeline_params.yaml
    $(METABABEL) -u $(srcdir)/btx_interval_model.yaml -t SINK -o btx_sink_timeline -p btx_timeline -c timeline --params $(srcdir)/btx_timeline_params.yaml
TApplencourt commented 11 months ago

Good enough, it was not the main of this PR :) I just merged it, so we can move forward :)