search

argonne-lcf / balsam

High throughput workflows and automation for HPC
77 stars 21 forks source link

Remove CUDA specific code from the AppRun class and move it into machine specific subclasses #355

Open cms21 opened 1 year ago

cms21 commented 1 year ago

The _set_envs() routine in the AppRun class has CUDA specific code (here: https://github.com/argonne-lcf/balsam/blob/9a02ef066ba66a09ff59a600b89e84088618b82f/balsam/platform/app_run/app_run.py#L143)

We should remove this and move it to the subclasses for machines that need it.