argonne-lcf / balsam

High throughput workflows and automation for HPC
76 stars 21 forks source link

Server sort #370

Closed cms21 closed 1 year ago

cms21 commented 1 year ago

This includes a new settings parameter sort_by that when set to long_large_first will apply an alternate sorting of jobs on the server, prioritizing the longest running jobs (as determined by wall_time_min) first. Response to #367

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.10% :tada:

Comparison is base (1d23048) 60.83% compared to head (ff9dd8c) 60.93%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #370 +/- ## ========================================== + Coverage 60.83% 60.93% +0.10% ========================================== Files 157 157 Lines 9615 9627 +12 Branches 1257 1259 +2 ========================================== + Hits 5849 5866 +17 + Misses 3508 3501 -7 - Partials 258 260 +2 ``` | [Files Changed](https://app.codecov.io/gh/argonne-lcf/balsam/pull/370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [balsam/\_api/bases.py](https://app.codecov.io/gh/argonne-lcf/balsam/pull/370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YmFsc2FtL19hcGkvYmFzZXMucHk=) | `54.47% <ø> (ø)` | | | [balsam/site/launcher/\_serial\_mode\_master.py](https://app.codecov.io/gh/argonne-lcf/balsam/pull/370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YmFsc2FtL3NpdGUvbGF1bmNoZXIvX3NlcmlhbF9tb2RlX21hc3Rlci5weQ==) | `87.82% <ø> (ø)` | | | [balsam/server/models/crud/sessions.py](https://app.codecov.io/gh/argonne-lcf/balsam/pull/370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YmFsc2FtL3NlcnZlci9tb2RlbHMvY3J1ZC9zZXNzaW9ucy5weQ==) | `87.70% <40.00%> (-4.47%)` | :arrow_down: | | [balsam/config/config.py](https://app.codecov.io/gh/argonne-lcf/balsam/pull/370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YmFsc2FtL2NvbmZpZy9jb25maWcucHk=) | `81.44% <100.00%> (+0.06%)` | :arrow_up: | | [balsam/schemas/session.py](https://app.codecov.io/gh/argonne-lcf/balsam/pull/370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YmFsc2FtL3NjaGVtYXMvc2Vzc2lvbi5weQ==) | `93.93% <100.00%> (+0.18%)` | :arrow_up: | | [balsam/site/job\_source.py](https://app.codecov.io/gh/argonne-lcf/balsam/pull/370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YmFsc2FtL3NpdGUvam9iX3NvdXJjZS5weQ==) | `68.70% <100.00%> (+0.48%)` | :arrow_up: | | [balsam/site/launcher/\_mpi\_mode.py](https://app.codecov.io/gh/argonne-lcf/balsam/pull/370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YmFsc2FtL3NpdGUvbGF1bmNoZXIvX21waV9tb2RlLnB5) | `77.71% <100.00%> (+0.12%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/argonne-lcf/balsam/pull/370/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.