argonui / SCED

41 stars 15 forks source link

Improve Bless/Curse Manager #516

Closed Entrox-Licher closed 9 months ago

Entrox-Licher commented 9 months ago

The Bless/Curse Manager has several areas that I feel could be improved upon, and given the upcoming influx of bless/curse cards, it will be good to tackle these before Feast releases (on the mod that is).

These are all the main issues that come to mind at the moment, I'll update this issue thread with more if they occur to me. Cheers!

Chr1Z93 commented 9 months ago

1) I don't really understand the first point, except that there is no tracking of manual edits to the chaos bag. My takeaway would be to remove the additional bless / curse containers since they are obsolete due to the manager and it's so long in use that it's highly likely to not break.

2) I agree that a context menu to return a token directly on the tokens would be useful. The "Take/Return" option is mostly for legacy support - I don't see any reason to improve this since no one should be using this at all.

3) Very good point! I think we could just have a small XML UI that is either always visible or visible onHover of the manager.

4) I agree that the position is kind of awkward, but the main advantage is that this is central. I don't like moving it outside of the main playarea.

Glitchy-Tozier commented 9 months ago

Finally, the Manager is located in a really awkward position, away from all other objects that interact with the chaos bag. I would recommend moving it either up near the chaos bag itself or near the Token Arranger & Chaos Bag Manager

While I agree that a position near the chaos bag would quite intuitive, I think the most important thing is to keep the bless/curse manager easily accessible.

I think the main drawback atm is that the bless/curse manager isn't that accessible to players red and green.

An option could be to have some small UI near the "draw chaos token" button. I'm not 100% convinced of that, though. + Intuitive position + Handy for removing bless/curse tokens after drawing them - Takes up important space - Removes the important aspect of "I see someone else's hand hovering over the global b/c manager, meaning I won't have to add/remove the tokens".

Chr1Z93 commented 9 months ago

Finally, the Manager is located in a really awkward position, away from all other objects that interact with the chaos bag. I would recommend moving it either up near the chaos bag itself or near the Token Arranger & Chaos Bag Manager

While I agree that a position near the chaos bag would quite intuitive, I think the most important thing is to keep the bless/curse manager easily accessible.

I think the main drawback atm is that the bless/curse manager isn't that accessible to players red and green.

An option could be to have some small UI near the "draw chaos token" button. I'm not 100% convinced of that, though. + Intuitive position + Handy for removing bless/curse tokens after drawing them - Takes up important space - Removes the important aspect of "I see someone else's hand hovering over the global b/c manager, meaning I won't have to add/remove the tokens".

Thanks for the idea! What do you think of a global UI (at the edge of your screen) for handling bless / curses? Could be collapsible and only show in full size when hovered

Glitchy-Tozier commented 9 months ago

Thanks for the idea! What do you think of a global UI (at the edge of your screen) for handling bless / curses? Could be collapsible and only show in full size when hovered

I thought about it, and there's some interesting pro & con arguments. Unfortunately, I think the cons outweigh the pros:

Pro

It's comfortable. Wherever you are on the table, you have instant control over bless & curse tokens. Additionally, it seems like we could expand on that Idea and and move all of the chaos-token stuff there. It sounds absolutely sick being able to hover a button on the side of your screen and seeing what tokens currently are in the bag, and being able to add/remove tokens. (basically moving the token arranger and token manager in there. They both seem kind of out of place anyway at the moment)

Con

I feel like this change would work against another core design philosophy of SCED. To me it seems like the current structure is to have everything on the side of the screen matter only when setting up the campaign (and sometimes in-between scenarios)

This is why I feel the current design makes you use the buttons on the side of your screen only for setting up the campaign, and then wants you to forget about them while actually playing. Moving everything token-related over there means making those buttons relevant mid-scenario, which is different than the established design.


Tbh, I see both sides being strong arguments. What do you think?

Chr1Z93 commented 9 months ago

I agree with your points if this was about moving all token related functionality into a separate UI. But as you explained, this falls flat since it would be a) a bunch of additional information and b) not something you need all the time. So I'd like to ask you to rethink your stance about this matter for just the bless/curse manager (since you actually need it during gameplay. The UI could feature a "burger-menu" like button (see doom counter's "Reset" button) or simply "minimize" if it is not hovered, so that it is not obtrusive when you don't need it.

Glitchy-Tozier commented 9 months ago

I don't quite understand what you're trying to say, could you rephrase it? Are you saying that despite those arguments, you'd like to move the bless/curse manager into the floating buttons?

Chr1Z93 commented 9 months ago

In my opinion your arguments were for a different situation and don't apply to this. I don't think transforming the Bless/Curse manager into an UI instead of a stationary object would break any current design principles.

Glitchy-Tozier commented 9 months ago

As far as I understood your proposal was to make it one of the floating buttons, the same positioning as the download-community-content-button and the button that lets you load helpers, correct? If so, the con-argument still applies. We would be adding something in that spot that regularly gets used mid-scenario. Which is contrary to the current usage of those elements.

Chr1Z93 commented 9 months ago

Ah, we're having a misunderstanding. This would not be a floating button, but rather a small "window" (more like the navigation overlay).

Glitchy-Tozier commented 9 months ago

My argument was targeted at anything floating, which iirc the navigation overlay did. It was that currently floating things that are "stuck to the screen" (as opposed to the table) are there to be used before campaigns/scenarios, but to be forgotten mid-scenario.

Also, irrespective of what we're planning, I realized I enjoy the current bless/curse manager :) It's nice and central, and it allows you to do anything you want with using a minimal amount of clicks. That's really important, especially with even more bless/curse cards coming out.

Another random idea: Numpad 1&2 currently aren't getting used, right? What is your opinion on

Numpad1         → Add Bless
Shift + Numpad1 → Remove Bless
Numpad2         → Add Curse
Shift + Numpad2 → Remove Curse
Chr1Z93 commented 9 months ago

Sadly, we can't use any modifiers for hotkeys (since TTS doesn't support that).

Chr1Z93 commented 9 months ago

Need to add: