argoproj-labs / argo-client-java

⚠️This repository is no longer maintained, please find your Java SDKs https://github.com/argoproj/argo-workflows/blob/master/docs/client-libraries.md
https://github.com/argoproj-labs/argo-client-gen
35 stars 22 forks source link

Parallelism as integer to avoid bad requests - unmarshalling errors #10

Closed rutkowskij closed 4 years ago

rutkowskij commented 4 years ago

String type will cause bad request with:

{"error":"json: cannot unmarshal string into Go struct field Template.workflow.spec.templates.parallelism of type int64","code":3,"message":"json: cannot unmarshal string into Go struct field Template.workflow.spec.templates.parallelism of type int64"}

rutkowskij commented 4 years ago

I haven't recognized that those model are generated previously. So what is source of truth and why this parameter (parallelism) is generated as String which cause an error?

rutkowskij commented 4 years ago

same for activeDeadlineSeconds

alexec commented 4 years ago

sorry - i missed this - the correct type for parrallelism is string, this is because you can template it, e.g. "{{parameters.whatever}}'