argoproj-labs / argo-rollouts-manager

Kubernetes Operator for Argo Rollouts controller.
https://argo-rollouts-manager.readthedocs.io/en/latest/
Apache License 2.0
84 stars 255 forks source link

Argo Rollouts configuration ConfigMap is not updated to latest value of OpenShiftRolloutPlugin #42

Closed jgwest closed 2 months ago

jgwest commented 4 months ago

Depends on fix to https://github.com/argoproj-labs/argo-rollouts-manager/issues/22

At present, if the value of the OpenShiftRolloutPlugin URL changes, for example, because we are shipping a new version of the plugin, it appears the ArgoRollouts ConfigMap will not be updated.

reconcileConfigMap contains this block of code:

    for _, plugin := range actualTrafficRouterPlugins {
        if plugin.Name == OpenShiftRolloutPluginName {
            // Openshift Route Plugin already present, nothing to do
            return nil
        }
    }

This block of code will exit the function if the plugin already exists, regardless of whether the URL matches the expected value.

Fix Criteria:

jgwest commented 4 months ago

Red Hat External issue tracker: https://issues.redhat.com/browse/GITOPS-4113