search

argoproj-labs / argo-rollouts-manager

Kubernetes Operator for Argo Rollouts controller.
https://argo-rollouts-manager.readthedocs.io/en/latest/
Apache License 2.0
84 stars 254 forks source link

Label/annotations on updated Deployments should be preserved #72

Open jgwest opened 1 week ago

jgwest commented 1 week ago

At present, when we reconcile a Rollout on an existing Deployment, and that Deployment contains labels/annotations that were not originally present, we will update the Deployment to remove those labels.

However, labels/annotations can be added to Deployments by other external tools in Kubernetes, and we should thus attempt to preserve them.

Likewise, we should not update a Deployment if no other fields changes besides the labels/annotations, as this can lead to excessive reconciliation.

jgwest commented 1 week ago

Red Hat External JIRA tracker: https://issues.redhat.com/browse/GITOPS-4890