search

argoproj-labs / argocd-agent

Redefining the multi cluster story of Argo CD
Apache License 2.0
79 stars 15 forks source link

chore(scripts): fix argocd deploy release version #214

Closed mikeshng closed 2 weeks ago

mikeshng commented 2 weeks ago

For the demo/dev env script, the ArgoCD deployments installed on the hub and spoke are using the latest tag instead of the release tag. This is due to the kustomization yamls are all using ?ref=stable but the argocd github repo still references latest (bug with argocd repo?). For example, https://github.com/argoproj/argo-cd/blob/stable/manifests/base/server/argocd-server-deployment.yaml#L21

This fix is to replace the latest tag with the latest stable release tag.

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.89%. Comparing base (46b9eea) to head (685f3fd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #214 +/- ## ======================================= Coverage 46.89% 46.89% ======================================= Files 57 57 Lines 4956 4956 ======================================= Hits 2324 2324 Misses 2451 2451 Partials 181 181 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mikeshng commented 2 weeks ago

All the files are copied to a tmp folder first before the sed modifications so it should be ok. A few lines above:

apply() {
    TMP_DIR=`mktemp -d`
    echo "-> TMP_DIR is $TMP_DIR"
    cp -r ${SCRIPTPATH}/* $TMP_DIR