argoproj-labs / argocd-agent

Redefining the multi cluster story of Argo CD
Apache License 2.0
81 stars 15 forks source link

refactor: Improve namespace handling in AppInformer #215

Closed jannfis closed 3 weeks ago

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 50.00000% with 35 lines in your changes missing coverage. Please review.

Project coverage is 46.75%. Comparing base (46b9eea) to head (50664ad).

Files with missing lines Patch % Lines
principal/options.go 0.00% 12 Missing :warning:
cmd/principal/main.go 0.00% 10 Missing :warning:
principal/server.go 69.23% 8 Missing :warning:
internal/informer/application/options.go 40.00% 3 Missing :warning:
internal/informer/application/appinformer.go 87.50% 1 Missing :warning:
internal/informer/appproject/projectinformer.go 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #215 +/- ## ========================================== - Coverage 46.89% 46.75% -0.15% ========================================== Files 57 57 Lines 4956 4986 +30 ========================================== + Hits 2324 2331 +7 - Misses 2451 2474 +23 Partials 181 181 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jannfis commented 3 weeks ago

Will be replaced by a major overhaul of the AppInformer