Open chetan-rns opened 6 days ago
Attention: Patch coverage is 44.24460%
with 155 lines
in your changes missing coverage. Please review.
Project coverage is 47.21%. Comparing base (
72eaea7
) to head (2525ac2
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Great stuff, @chetan-rns!
I'm starting a review cycle. Please bear with me, as my reviews are dripping in :)
ACK
that is sent by the principal/agent when an event is processed successfully.EventWriter
keeps track of the latest events and sends them on the gRPC stream. Both the agent and the principal will add events to theEventWriter
instead of directly sending them to the gRPC stream. TheEventWriter
will send the events with exponential backoff until we receive an ACK from the other side. It continuously loops over the waiting events and sends them to the other side with minimal delay. The goal was to propagate the events as soon as possible with minimal delay and without blocking the other events.UID
(resourceID) andresourceVersion
(eventID) to the cloudevent as extensions. We do this to map an event to a particular state of a resource. For example, when we receive an ACK for an event we want to know if the ACK is for the latest version of a resource.Note: I think there are multiple ways of designing this and I'm happy to update the approach based on the feedback.
Other choices that were considered:
Fixes: https://github.com/argoproj-labs/argocd-agent/issues/117