search

argoproj-labs / argocd-autopilot

Argo-CD Autopilot
https://argocd-autopilot.readthedocs.io/en/stable/
Apache License 2.0
893 stars 121 forks source link

Specifying a specific argocd version with 'Repo bootstrap --app' is missing a patch #559

Open AlexEndris opened 7 months ago

AlexEndris commented 7 months ago

As stated by @noam-codefresh here https://github.com/argoproj-labs/argocd-autopilot/issues/557#issuecomment-1940654562 the autopilot installation is missing a crucial patch in the kustomization.yaml resulting in a broken installation when using the --app flag for specifying an argocd version without referencing this repository's kustomization.yaml

As a side note: It would be good if the installation didn't reference this repository's /base or /ha kustomize folder in the first place to give more direct control over the version of argocd that is being used, if at all feasible.

noam-codefresh commented 7 months ago

@AlexEndris

As a side note: It would be good if the installation didn't reference this repository's /base or /ha kustomize folder in the first place to give more direct control over the version of argocd that is being used, if at all feasible. i am thinking about changing the installation process to just put the patches in the user's git repository, and then the reference will be explicit, and easy to manually upgrade. and no more "passing" through the argocd-autopilot repository at all. wdyt?

AlexEndris commented 7 months ago

All I can wish for! Thank you for being so quick about it! Very much appreciated!