argoproj-labs / argocd-extension-metrics

An Argo CD extension to enable visualization of metrics in Argo CD UI.
Apache License 2.0
111 stars 25 forks source link

Big Docs Mistake..? #73

Closed ForbiddenEra closed 2 months ago

ForbiddenEra commented 5 months ago

Docs say to use:

policy.csv: |-
  p, role:readonly, extensions, invoke, httpbin, allow

And I get No metrics available .. check my logs, says I'm not authorized to use extension metrics (even though I'm admin)

so I go hmm...

policy.csv: |-
  p, role:admin, extensions, invoke, httpbin, allow

Still no go.. so I go hmmmmmmmmmmm........

policy.csv: |-
  p, role:admin, extensions, invoke, metrics, allow

annnnnnd whatdoyaknow?! BAM image

so where did httpbin come from? I'm using basically exactly the default config..?

The docs also show:

extension.config: |-
  extensions:
    - name: metrics
      backend:
        services:
          - url: <METRICS_SERVER_URL>

and https://argo-cd.readthedocs.io/en/stable/developer-guide/extensions/proxy-extensions/ shows:

apiVersion: v1
kind: ConfigMap
metadata:
  name: argocd-cm
  namespace: argocd
data:
  extension.config: |
    extensions:
    - name: httpbin
      backend:
        connectionTimeout: 2s
        keepAlive: 15s
        idleConnectionTimeout: 60s
        maxIdleConnections: 30
        services:
        - url: http://httpbin.org
          headers:
          - name: some-header
            value: '$some.argocd.secret.key'
          cluster:
            name: some-cluster
            server: https://some-cluster

as an example for proxy extensions...... Did someone just copy/paste and forget to update RBAC to metrics or something?

mcanevet commented 2 months ago

@ForbiddenEra I opened a PR for that: https://github.com/argoproj-labs/argocd-extension-metrics/pull/65

leoluz commented 2 months ago

Thank you @mcanevet for fixing that doc.