argoproj-labs / argocd-extension-metrics

An Argo CD extension to enable visualization of metrics in Argo CD UI.
Apache License 2.0
111 stars 25 forks source link

Should Image be set to `latest` in Deployment.yaml? #80

Open avo-sepp opened 1 month ago

avo-sepp commented 1 month ago

https://github.com/argoproj-labs/argocd-extension-metrics/blob/2111143fd4ccb897d35a286b5b263d4b8b4f9101/manifests/deployment.yaml#L17

The install instructions utilize manifests which are set to a specific Git Tag. However, the deployment in that tag uses a latest image. This means it's possible for a team to believe they are pegged to a specific version, however the metrics server has continued to update and move forward.

For some companies, policies prohibit the use of latest tags.

I believe the image tag here should match the Git version. Similar to how the core ArgoCD app functions.