argoproj-labs / argocd-image-updater

Automatic container image update for Argo CD
https://argocd-image-updater.readthedocs.io/en/stable/
Apache License 2.0
1.22k stars 252 forks source link

feat: Trigger image update check on incoming webhook and/or other triggers #1

Open jannfis opened 4 years ago

jannfis commented 4 years ago

Is your feature request related to a problem? Please describe.

Currently, ArgoCD Image Updater only polls container registries for new tags at a given interval. Depending on the number of images and registries to be checked, this can lead to an overwhelming number of requests and takes a lot of time.

Describe the solution you'd like

Update checks for images should also be triggered asynchronously, i.e. by a webhook on image push to the registry.

ghostheory commented 3 years ago

Per some of the constraints at my employer, this feature would be a game changer there. I was wondering if there is a timeline on this, and if there is anything I can do to help (unfortunately, I do not know Go).

Ladorie commented 3 years ago

Per some of the constraints at my employer, this feature would be a game changer there. I was wondering if there is a timeline on this, and if there is anything I can do to help (unfortunately, I do not know Go).

I second this feature. Would be very helpful for us as well.

tylerbroadbent commented 3 years ago

Same here! This would be a game changer and extremely valuable!

joshdwads commented 3 years ago

Serious game changer! This would be a great add.

nikelsj11 commented 3 years ago

+1

alexisbel1 commented 2 years ago

Game changer here!

gastonborba commented 2 years ago

Same here!

tuananh commented 2 years ago

@gastonborba i opened a PR earlier here. it's wip #284

Disturbing commented 2 years ago

Plz do this

djfinnoy commented 2 years ago

It would be amazing if the image updater could be triggered through the git webhook for refreshing argocd apps.

Git repositories POST to https://argocd.example.com/api/webhook, the image updater triggers for applications with annotations that match the git webhook. That way, all the user has to do is set some annotations, and then get a free ride with the existing ArgoCD git webhook functionality.

tuananh commented 2 years ago

git webhook is triggered very early in the CI process. at that moment, CI was just trigger and image is not built in.

the other information is git webhook payload doesn't have any information of the image tag, so image updater doesn't know which one to use for updating either.

chenfli commented 2 years ago

How about when the CI process completed the image creating it will send a web request to ArgoCD ? is it already implemented on Argo Events ?

binhnguyenduc commented 1 year ago

This would be a game changer for us as well. With a growing number of repositories and images, it takes quite sometime to update new image and it is slowing down our CD

tuananh commented 1 year ago

This would be a game changer for us as well. With a growing number of repositories and images, it takes quite sometime to update new image and it is slowing down our CD

Maybe you can continue on this pr https://github.com/argoproj-labs/argocd-image-updater/pull/284

gain620 commented 1 year ago

Any updates on this feature?

otherguy commented 1 year ago

Would be amazing to have

MrCorncob commented 1 year ago

tracking hundreds of images and my GCP project has exceeded the Snapshot api limit, this feature is really really important imo

victorbiga commented 1 year ago

This could be the implementation of API request as /api/webhook?name=app-name, however this is thin line. Github Webhook currently does not support OIDC or any other ways of authenticating, therefore wanting for the new rollout to start by un-authenticated request or not is another question

sidoverflow commented 2 months ago

would love some updates on this @jannfis

CreamyMiracle commented 2 months ago

This would make things exponentially easier for us. Currently we are forced to do nasty tricks to achieve similar functionality.

oubaydos commented 1 month ago

+1