argoproj-labs / argocd-image-updater

Automatic container image update for Argo CD
https://argocd-image-updater.readthedocs.io/en/stable/
Apache License 2.0
1.16k stars 239 forks source link

cannot use helm chart from public helm chart repositories #739

Open josedev-union opened 2 weeks ago

josedev-union commented 2 weeks ago

Describe the bug I deploy an application using airflow helm chart from https://airflow.apache.org chart repository. I can see that argocd-image-updater tries to push .argocd-source-<appName>.yaml file to the apache public helm chart repository, not to my application manifest git repo.

To Reproduce Here is the application spec yaml file.

metadata:
  annotations:
    argocd-image-updater.argoproj.io/write-back-method: git:secret:argo-cd/image-updater-gitops-repo
    argocd-image-updater.argoproj.io/git-branch: main
    argocd-image-updater.argoproj.io/image-list: main=mydocker/airflow:2.8.3
    argocd-image-updater.argoproj.io/main.update-strategy: digest
    argocd-image-updater.argoproj.io/main.helm.image-name: images.airflow.repository
    argocd-image-updater.argoproj.io/main.helm.image-tag: images.airflow.tag
  name: airflow-staging
spec:
  source:
    chart: airflow
    repoURL: https://airflow.apache.org
    targetRevision: 1.13.1
    helm:
      releaseName: airflow-staging
      values: |
        images:
          airflow:
            repository: mydocker/airflow
            tag: 2.8.3

Expected behavior .argocd-source-<appName>.yaml should be pushed to my own git repo, not to helm chart's repo.

chengfang commented 2 weeks ago

Thanks for reporting the issue. I'll take a look.

chengfang commented 4 days ago

It seems similar to https://github.com/argoproj-labs/argocd-image-updater/issues/558, where others shared their sample application configs with multi-source apps. You may want to take a look and compare with your app config.