fix the setting of environment variable ARGOCD_CONTROLLER_REPLICAS for dynamicScaling

[ishitasequeira]

What type of PR is this?

/kind bug

What does this PR do / why we need it:

Currently, when spec.controller.sharding.dynamicScalingEnabled feature is enabled on argocd-controller, we do not update the environment variable ARGOCD_CONTROLLER_REPLICAS with the correct number of replicas on the argocd-application-controller statefulset.

The PR fixes the logic of setting the number of replicas correctly in the environment variable of the statefulset pods.

Have you updated the necessary documentation?

• [ ] Documentation update is required by this PR.
• [ ] Documentation has been updated.

Which issue(s) this PR fixes:

Fixes https://issues.redhat.com/browse/GITOPS-3465

How to test changes / Special notes to the reviewer:

• Start the operator using

  ARGOCD_CLUSTER_CONFIG_NAMESPACES=argocd-e2e-cluster-config make install run

• Execute the kuttl test using the command

  kubectl kuttl test ./tests/k8s --config ./tests/kuttl-tests.yaml --test 1-032_validate_dynamic_scaling