Add More Banner Options to Argocd CR

[neevnuv]

What type of PR is this? /kind enhancement

What does this PR do / why we need it: It add the banner permanent and banner position options to the argocd cr

Have you updated the necessary documentation?

• [x] Documentation has been updated.
• [ ] Documentation update is required by this PR.

Which issue(s) this PR fixes: This PR adds an enhancement that allows easily to configure a banner's position and permanence

How to test changes / Special notes to the reviewer:

[svghadi]

Hi @neevnuv , operator supports .spec.extraConfig field which can be used for add extra configs in argocd-cm configmap. Do you think that could be an option for you? https://argocd-operator.readthedocs.io/en/latest/reference/argocd/#extra-config

We are trying to reduce ArgoCD CRD size so we might deprecate & remove some of the less used fields like .banner in future. Let me know if you find .spec.banner field useful. You can achieve the same result by using .spec.extraConfig.

Example:

apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
metadata:
  name: example-argocd
spec:
  extraConfig:
    "ui.bannercontent": "value"
    "ui.bannerurl": "value"
    "ui.bannerpermanent": "value"
    "ui.bannerposition": "value"

[neevnuv]

Hello @svghadi, Our team uses the .spec.banner option in the Argo cr, but the extraConfig option does also work for us, so we’ll be okay either way. You may close this issue if the banner field is planned to be deprecated in the future.