search

argoproj-labs / argocd-rbac-operator

Kubernetes Operator for Argo CD RBAC Management.
Apache License 2.0
18 stars 2 forks source link

feat: Add `finalizers` subresource to ArgoCDRole and ArgoCDRoleBindin… #11

Open filiprafaj opened 9 hours ago

filiprafaj commented 9 hours ago

Problem

Controllers were unable to manage finalizers on ArgoCDRole and ArgoCDRoleBinding resources due to missing subresource support in the CRDs, resulting e.g. in the following error:

error when adding finalizer: argocdrolebindings.rb sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler

Solution

Updated the ArgoCDRole and ArgoCDRoleBinding CRDs to include finalizers as a subresource, allowing more granular RBAC permissions to manage finalizers without requiring full update access on the main resources.

ggkhrmv commented 9 hours ago

Hi @filiprafaj, can u provide some details on the error? And preferably a way to reproduce it :) Thank you!

ggkhrmv commented 5 hours ago

The information about finalizers is saved in CRs metadata as of yet