search

argoproj-labs / argocd-vault-plugin

An Argo CD plugin to retrieve secrets from Secret Management tools and inject them into Kubernetes secrets
https://argocd-vault-plugin.readthedocs.io
Apache License 2.0
812 stars 190 forks source link

AVP_VERSION didn't match tag release #410

Open dje4om opened 1 year ago

dje4om commented 1 year ago

Hi,

If we refer to the raw link to a specific tag release of the deployment file, we don't have the expected image version :), i had issues with userpass feature available since 1.13.

I currently had to patch on my side the AVP_VERSION env value.

erkanzileli commented 1 year ago

Hi, I see your point.

I can help with this but there are two solutions here:

  1. Update image tags in manifests on every new tag
  2. Use latest tag like argoproj/argo-cd does here

I'm always against manual work so I prefer the second one. Let's see what maintainers think about this.

erkanzileli commented 1 year ago

Similar issues:

dje4om commented 1 year ago

Hi,

The latest is not recommended here in my opinion. It is used for "dev" manifests only, you should compare with this manifest used for real deployments (doc) : https://github.com/argoproj/argo-cd/blob/v2.4.14/manifests/install.yaml, as you can see, they have bumped version of images. A bot is in charge of this task :) : https://github.com/argoproj/argo-cd/commit/029be590bfd5003d65ddabb4d4cb8a31bff29c18

erkanzileli commented 1 year ago

You're right. I liked that bot btw. We can do the same I guess. WDYT?