argoproj-labs / argocd-vault-plugin

An Argo CD plugin to retrieve secrets from Secret Management tools and inject them into Kubernetes secrets
https://argocd-vault-plugin.readthedocs.io
Apache License 2.0
812 stars 190 forks source link

delineasecretserver is not supported #570

Closed HSoulat closed 11 months ago

HSoulat commented 11 months ago

Describe the bug delineasecretserver do not seems supported by v1.15.0 & v1.16.1 plugin.

To Reproduce Configure plugin to use Delinea Sercret Server

generate:
        command:
          - argocd-vault-plugin
          - generate
          - "-s"
          - "vault-configuration"
          - "."
apiVersion: v1
kind: Secret
metadata:
  name: vault-configuration
data:
  AVP_TYPE: ZGVsaW5lYXNlY3JldHNlcnZlcgo=
  AVP_DELINEA_URL: ...
  AVP_DELINEA_USER: ...
  AVP_DELINEA_PASSWORD: ...
type: Opaque

If we try to execute the generate from avp container : argocd-vault-plugin generate -s vault-configuration . Error: Must provide a supported Vault Type, received delineasecretserver

Expected behavior Since version v1.15.0 this backend is marked as supported.

Screenshots/Verbose output

2023/10/26 09:45:53 reading configuration from secret vault-configuration
2023/10/26 09:45:53 reading configuration from environment, overriding any previous settings
2023/10/26 09:45:53 AVP configured with the following settings:

2023/10/26 09:45:53 avp_delinea_password: ...

2023/10/26 09:45:53 avp_delinea_url: ...

2023/10/26 09:45:53 avp_kv_version: 2

2023/10/26 09:45:53 avp_delinea_user: ...

2023/10/26 09:45:53 avp_type: delineasecretserver

Error: Must provide a supported Vault Type, received delineasecretserver
HSoulat commented 11 months ago

I may be wrong but it seems that import in pkg/config/config.go point to an incorrect url. delineasecretserver "github.com/DelineaXPM/tss-sdk-go/v2/server" should be delineasecretserver "github.com/DelineaXPM/tss-sdk-go/server"

werne2j commented 11 months ago

Check the value of the type to make sure there isn’t a newline at the end. https://github.com/argoproj-labs/argocd-vault-plugin/issues/301#issuecomment-1045174207. Your error says that the configuration is wrong, not that the backend itself isnt working. (Not saying that couldnt be the case). But also https://pkg.go.dev/github.com/DelineaXPM/tss-sdk-go/v2

HSoulat commented 11 months ago

@werne2j thanks, that was a newline at the end of base64 value.