search

argoproj-labs / argocd-vault-plugin

An Argo CD plugin to retrieve secrets from Secret Management tools and inject them into Kubernetes secrets
https://argocd-vault-plugin.readthedocs.io
Apache License 2.0
784 stars 185 forks source link

Sidecar example code fails to download file #607

Open BrianHicks opened 4 months ago

BrianHicks commented 4 months ago

Describe the bug

Since the curl command doesn't use --fail, a 404 fails to download the binary silently, resulting in a file which only contains the text "Not found". Pointing AVP_VERSION at an existing release fixes the example code.

This is probably a simple fix, but I wanted to raise it to you so you could decide whether or not --fail makes sense to include.

To Reproduce Steps to reproduce the behavior:

  1. Install the example sidecar code from /manifests/cmp-sidecar/argocd-repo-server.yaml in this repo
  2. Sync an app

Expected behavior argocd-vault-plugin runs successfully.