argoproj-labs / argocd-vault-plugin

An Argo CD plugin to retrieve secrets from Secret Management tools and inject them into Kubernetes secrets
https://argocd-vault-plugin.readthedocs.io
Apache License 2.0
812 stars 190 forks source link

Sidecar example code does not put binary in PATH #608

Open BrianHicks opened 7 months ago

BrianHicks commented 7 months ago

Describe the bug

The example code at /manifests/cmp-sidecar/argocd-repo-server.yaml does not end up mounting the argocd-vault-plugin binary in a directory included in PATH, so the example config at /manifests/cmp-sidecar/cmp-plugin.yaml cannot find it. Either explicitly referring to /usr/local/bin/argocd-vault-plugin in the config or remounting the binary at /usr/bin/argocd-vault-plugin solves the problem.

To Reproduce

Steps to reproduce the behavior:

  1. Deploy the cmp-sidecar manifest code (with #607 fixed)
  2. Try to sync an app
  3. Syncing fails with code 127 because the binary cannot be found

Expected behavior

As in #607, I expected the example manifests linked to from the installation docs to more-or-less work.

Additional context

Just a side note, even after successfully executing the binary it looks like there's still configuration I have to do. That's fine, and I kind of expected it, but as far as I can see the installation guide doesn't say that. It might be helpful to add to the docs too. 😄