feat[ibmsm]: Add support for service_credentials secret type

argoproj-labs / argocd-vault-plugin

An Argo CD plugin to retrieve secrets from Secret Management tools and inject them into Kubernetes secrets

https://argocd-vault-plugin.readthedocs.io

Apache License 2.0

812 stars 190 forks source link

feat[ibmsm]: Add support for service_credentials secret type #629

Open jgawor opened 5 months ago

jgawor commented 5 months ago

Description

Add support for service_credentials secret type.

Checklist

Please make sure that your PR fulfills the following requirements:

[x] Reviewed the guidelines for contributing to this repository
[x] The commit message follows the Conventional Commits Guidelines.
[x] Tests for the changes have been updated
[x] Are you adding dependencies? If so, please run go mod tidy -compat=1.21 to ensure only the minimum is pulled in.
[x] Docs have been added / updated
[ ] Optional. My organization is added to USERS.md.

Type of Change

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] New tests
[ ] Build/CI related changes
[x] Documentation content changes
[ ] Other (please describe)

Other information

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.91%. Comparing base (42a43f0) to head (8bf621a). Report is 11 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #629 +/- ## ========================================== + Coverage 72.16% 73.91% +1.74% ========================================== Files 26 26 Lines 1994 1606 -388 ========================================== - Hits 1439 1187 -252 + Misses 458 314 -144 - Partials 97 105 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jgawor commented 4 months ago

@werne2j could you please take a look at this PR? thanks.

jgawor commented 3 months ago

@werne2j updated now

jgawor commented 3 months ago

@werne2j one more ping :)

jgawor commented 2 months ago

@werne2j one more ping

jgawor commented 2 months ago

@werne2j and one more ping.

jgawor commented 1 month ago

@jkayani maybe you can merge?

werne2j commented 4 days ago

@jgawor looks like there are conflicts. Once resolved i will merge this in.